fix: empty space for the empty description field#5797
Closed
MohammadAlhallaq wants to merge 1 commit intoBookStackApp:developmentfrom
Closed
fix: empty space for the empty description field#5797MohammadAlhallaq wants to merge 1 commit intoBookStackApp:developmentfrom
MohammadAlhallaq wants to merge 1 commit intoBookStackApp:developmentfrom
Conversation
Member
|
Thanks for offering this @MohammadAlhallaq, and sorry for the very delayed response. Currently this method would impact legitimate scenarios (empty lines between content). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix empty description rendering
CLOSES #5724
Centralized empty HTML trimming in HasHtmlDescription.php and updated views to prevent rendering
tags for empty descriptions.